fix(checkbox): support high contrast mode in Firefox on Windows #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 101 101
Lines 4363 4363
Branches 563 563
======================================
Hits 4289 4289
Misses 74 74Continue to review full report at Codecov.
|
aprigogin
commented
Jun 13, 2018
| @@ -69,10 +69,8 @@ | |||
| } | |||
|
|
|||
| @mixin mdc-checkbox-ink-color($color) { | |||
| .mdc-checkbox__checkmark-path { | |||
| // !important is needed here because a stroke must be set as an attribute on the SVG in order | |||
There was a problem hiding this comment.
I did not find this comment being true at all. In fact I've moved stroke color definition from html to css.
acdvorak
changed the title
kfranqueiro
pushed a commit
that referenced
this pull request
Jun 19, 2018
(cherry picked from commit 2bd52c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The
stroke="white"SVG attribute has been removed as it is no longer needed.