feat(text-field): Support for types- color, date, datetime-local, etc #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fine? Do I need fix something or make any changes? |
packages/mdc-textfield/foundation.js
Outdated
| @@ -49,9 +48,15 @@ class MDCTextFieldFoundation extends MDCFoundation { | |||
| return !this.isValid() && !this.isFocused_; | |||
| } | |||
|
|
|||
| /** @return {boolean} */ | |||
There was a problem hiding this comment.
Change to @private and update the name to shouldAlwaysFloat_.
/**
* @return {boolean}
* @private
*/
get shouldAlwaysFloat_() {
const type = this.getNativeInput_().type;
return ALWAYS_FLOAT_TYPES.indexOf(type) >= 0;
}
/** @return {boolean} */
get shouldFloat() {
return this.shouldAlwaysFloat_ || this.isFocused_ || !!this.getValue() || this.isBadInput_();
}
packages/mdc-textfield/foundation.js
Outdated
| /** | ||
| * @param {string} type The type to set on the input Element. | ||
| */ | ||
| setType(type) { |
There was a problem hiding this comment.
Dynamically changing type isn't a common use case. This should be removed.
packages/mdc-textfield/foundation.js
Outdated
| /** | ||
| * @return {string} The type of the input Element. | ||
| */ | ||
| getType() { |
|
@williamernest Sorry for the late response. I have made the changes you suggested. |
Codecov Report
@@ Coverage Diff @@
## master #2854 +/- ##
==========================================
+ Coverage 98.36% 98.36% +<.01%
==========================================
Files 120 120
Lines 5123 5125 +2
Branches 638 637 -1
==========================================
+ Hits 5039 5041 +2
Misses 84 84
Continue to review full report at Codecov.
|
|
@namannehra Sorry for the delay. Thanks for fixing this for us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Label will always float for the following types as they show some UI even if value is empty
Added
getTypeandsetTypemethods to foundation.setTypemust be used to update type after initialisation.