-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fab): Restore horizontal alignment in IE11 #2715
Conversation
It's better than it was, and addresses the issue regarding the icon being on the right, but it's still off in IE11. We might want to just accept these changes as they are now, to fix the immediate regression, but file a bug to fix this in IE11 once and for all. The icon on the fab in the bottom right was centered in the second picture. |
Codecov Report
@@ Coverage Diff @@
## master #2715 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 98 98
Lines 4231 4231
Branches 538 538
=======================================
Hits 4167 4167
Misses 64 64 Continue to review full report at Codecov.
|
126106b
to
28978f8
Compare
I can file a bug for the vertical alignment. AFAICT, that vertical alignment was a thing (at least according to the in-repo demos and screenshot tests) even prior to the changes to support SVGs in FABs. The baffling part, though, is that if I throw FABs into a codepen running 0.34.1, they align fine in IE 11... but in our demos on 0.34.1, they don't. Removing normalize.css makes no difference. Edit: Filed #2752. |
28978f8
to
e6bb134
Compare
e6bb134
to
a420fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also fixes markup to move
material-icons
to the icon element, as pointed out by Will in #2692.