Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-app-bar): Replace margin-top in media query with padding-top #2704

Merged
merged 2 commits into from
May 15, 2018

Conversation

williamernest
Copy link
Contributor

@williamernest williamernest commented May 4, 2018

Missed a change to mobile fixed-adjust class with #2643

Resolves #2712.

@codecov-io
Copy link

codecov-io commented May 4, 2018

Codecov Report

Merging #2704 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2704   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files          98       98           
  Lines        4230     4230           
  Branches      537      537           
=======================================
  Hits         4166     4166           
  Misses         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4b9ac...a33c690. Read the comment docs.

@alex-page
Copy link
Contributor

If anyone is experiencing this issue and needs a temporary patch they can do this:

@media (max-width: 599px){
	.mdc-top-app-bar--fixed-adjust {
		margin-top: 0;
		padding-top: $mdc-top-app-bar-mobile-row-height;
	}
}

@williamernest williamernest merged commit 88c78b3 into master May 15, 2018
@williamernest williamernest deleted the fix/top-app-bar/fixed-adjust branch May 15, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top App Bar spacing issue
4 participants