feat(ripple): Call layout on each activation #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2018 11:07
Unbounded still needs layout called immediately to compute its position.
This was referenced Apr 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
+ Coverage 98.76% 98.76% +<.01%
==========================================
Files 98 98
Lines 4195 4198 +3
Branches 533 535 +2
==========================================
+ Hits 4143 4146 +3
Misses 52 52
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
layoutInternal_from withinanimateActivation_so thatlayoutdoesn't need to be called on bounded ripples when the page resizes or the surface becomes visible.Unbounded ripples still need to run layout logic in init and on resize, because they dynamically determine positioning/size for the hover/focus shade as well as the press ripple (whereas bounded ripples only dynamically determine positioning/size for the press ripple, which can be done upon activation).
This also enables us to remove code that invokes ripple layout logic in a few components that use bounded ripples, which I'll send separate PRs for.
Fixes #2207.