fix(button): Fix vertical alignment of contents #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2534 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 104 104
Lines 4226 4226
Branches 530 530
=======================================
Hits 4168 4168
Misses 58 58Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the horizontal-padding mixin, we unwittingly removed styles that set 0 top and bottom padding, which is important for overriding UA stylesheets. I also didn't need to remove the line-height style when switching to inline-flex.
Also added a note to the readme to clarify the case of customizing padding when stroke is used.