-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(snackbar): Doesn't close while other element is focused #2183
fix(snackbar): Doesn't close while other element is focused #2183
Conversation
One test failed (TEST_SUITE=unit): but it looks like tests configuration problem: |
418760e
to
6569e5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
==========================================
- Coverage 98.36% 98.24% -0.12%
==========================================
Files 120 120
Lines 5125 5129 +4
Branches 637 638 +1
==========================================
- Hits 5041 5039 -2
- Misses 84 90 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This component will be rebuilt in the future, but this PR fixes the issue for now. Thanks for submitting!
Snackbar doesn't close when any element on page receives focus event while snackbar is opened and snackbar has empty action text.
Fixes #1918
Steps to reproduce:
Snackbar should close, but it doesn't.