Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snackbar): Doesn't close while other element is focused #2183

Merged

Conversation

piotr-cz
Copy link
Contributor

@piotr-cz piotr-cz commented Feb 5, 2018

Snackbar doesn't close when any element on page receives focus event while snackbar is opened and snackbar has empty action text.

Fixes #1918

Steps to reproduce:

  1. Go to https://material-components-web.appspot.com/snackbar.html
  2. Delete Action Text value
  3. Click on Show
  4. Press Shift-Tab to focus some element on the page (like Action Text input element)

Snackbar should close, but it doesn't.

@piotr-cz
Copy link
Contributor Author

One test failed (TEST_SUITE=unit): but it looks like tests configuration problem: The SUID sandbox helper binary was found, but is not configured correctly

@piotr-cz piotr-cz force-pushed the fix/snackbar-does-not-close branch from 418760e to 6569e5f Compare May 25, 2018 09:11
@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #2183 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
- Coverage   98.36%   98.24%   -0.12%     
==========================================
  Files         120      120              
  Lines        5125     5129       +4     
  Branches      637      638       +1     
==========================================
- Hits         5041     5039       -2     
- Misses         84       90       +6
Impacted Files Coverage Δ
packages/mdc-snackbar/foundation.js 96.02% <100%> (-3.98%) ⬇️
packages/mdc-snackbar/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d02f1f...6c63cc4. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This component will be rebuilt in the future, but this PR fixes the issue for now. Thanks for submitting!

@williamernest williamernest merged commit e161cc0 into material-components:master Jul 31, 2018
@piotr-cz piotr-cz deleted the fix/snackbar-does-not-close branch August 1, 2018 07:46
@jamesmfriedman jamesmfriedman mentioned this pull request Aug 23, 2018
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snackbar does not always dismiss when activated via keyboard
3 participants