chore(button): removed unused imports from css #2093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2093 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3720 3720
Branches 485 485
=======================================
Hits 3699 3699
Misses 21 21Continue to review full report at Codecov.
|
packages/mdc-button/_mixins.scss
Outdated
| @@ -15,9 +15,7 @@ | |||
| // | |||
|
|
|||
| @import "@material/elevation/mixins"; | |||
| @import "@material/ripple/mixins"; | |||
There was a problem hiding this comment.
This file is definitely using mdc-ripple and mdc-states mixins, so this should stay
(it probably works without it because mdc-button.scss includes it, but IMO we should leave imports when their contents are directly referenced, otherwise this file could break in the future if imports in another file change)
There was a problem hiding this comment.
Ya it is also in mdc-button.scss. I haven't seen any one pattern to determine if all should be in the mdc-foo/mdc-foo.scss file or the mdc-foo/_mixins.scss file. I will add these back
packages/mdc-button/_mixins.scss
Outdated
| @import "@material/theme/functions"; | ||
| @import "@material/theme/mixins"; |
There was a problem hiding this comment.
This file is still using mdc-theme-prop so we should leave this
acdvorak
changed the title
No description provided.