Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): Fix slidable drawer's closed position in RTL #1957

Merged
merged 4 commits into from
Jan 23, 2018
Merged

fix(drawer): Fix slidable drawer's closed position in RTL #1957

merged 4 commits into from
Jan 23, 2018

Conversation

acdvorak
Copy link
Contributor

Fixes #1930

@codecov-io
Copy link

codecov-io commented Jan 13, 2018 •
edited
Loading

Codecov Report

Merging #1957 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   99.43%   99.43%   -0.01%     
==========================================
  Files          84       84              
  Lines        3717     3710       -7     
  Branches      485      484       -1     
==========================================
- Hits         3696     3689       -7     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-textfield/helper-text/foundation.js 93.1% <0%> (-1.5%) ⬇️
packages/mdc-ripple/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-menu/simple/constants.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da007f5...a4fc820. Read the comment docs.

@acdvorak acdvorak mentioned this pull request Jan 19, 2018
Closed
moog16
moog16 reviewed Jan 20, 2018
View reviewed changes
packages/mdc-drawer/temporary/mdc-temporary-drawer.scss Outdated
@@ -87,6 +83,12 @@
}
}

@include mdc-rtl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also broken in persistent drawer as well. Maybe just include this in @mixin mdc-slideable-drawer ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, padawan! Done 😀

moog16
moog16 suggested changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add fix for persistent drawer?

@acdvorak acdvorak changed the title fix(drawer): Fix temporary drawer's closed position in RTL fix(drawer): Fix slidable drawer's closed position in RTL Jan 23, 2018
moog16
moog16 approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acdvorak acdvorak merged commit 486ec87 into master Jan 23, 2018
@acdvorak acdvorak deleted the fix/drawer/rtl-position branch January 23, 2018 01:47
@bonniezhou bonniezhou mentioned this pull request Jan 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moog16 moog16 moog16 approved these changes

Assignees

@moog16 moog16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdvorak @codecov-io @moog16