Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): Don't allow graphic to shrink when text overflows #1943

Merged
merged 3 commits into from
Jan 23, 2018

Conversation

acdvorak
Copy link
Contributor

Fixes #1941

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1943 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   99.43%   99.43%   +<.01%     
==========================================
  Files          84       84              
  Lines        3717     3721       +4     
  Branches      485      484       -1     
==========================================
+ Hits         3696     3700       +4     
  Misses         21       21
Impacted Files Coverage Δ
packages/mdc-textfield/helper-text/foundation.js 93.1% <0%> (-1.5%) ⬇️
packages/mdc-ripple/foundation.js 100% <0%> (ø) ⬆️
packages/mdc-menu/simple/constants.js 100% <0%> (ø) ⬆️
packages/mdc-select/foundation.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8848fcc...8c064b2. Read the comment docs.

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acdvorak acdvorak merged commit da007f5 into master Jan 23, 2018
@acdvorak acdvorak deleted the fix/list/graphic-width branch January 23, 2018 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants