chore(text-field): Move idle outline style method #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `getIdleOutlineStyleValue` method from textfield adapter. Add `getIdleOutlineStyleValue` method to textfield outline adapter. Update tests to check new functionality.
patrickrodee
commented
Jan 9, 2018
| @@ -52,6 +52,12 @@ class MDCTextFieldOutline extends MDCComponent { | |||
| const path = this.root_.querySelector(strings.PATH_SELECTOR); | |||
| path.setAttribute('d', value); | |||
| }, | |||
| getIdleOutlineStyleValue: (propertyName) => { | |||
| const idleOutlineElement = this.root_.parentNode.querySelector(strings.IDLE_OUTLINE_SELECTOR); | |||
There was a problem hiding this comment.
This is the only real funkiness. Since the idle outline is a sibling of the outline root, we need to access the parent node to be able to query it.
Remove getIdleOutlineStyleValue from textfield foundation default adapter and test cases
Remove the extraneous `getIdleOutlineStyleValue` from text field foundation default adapter.
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3721 3721
Branches 484 484
=======================================
Hits 3700 3700
Misses 21 21
Continue to review full report at Codecov.
|
patrickrodee
added a commit
that referenced
this pull request
Jan 9, 2018
Remove `getIdleOutlineStyleValue` method from text field adapter as it was unused following the merge of #1911
patrickrodee
added a commit
that referenced
this pull request
Jan 9, 2018
Remove `getIdleOutlineStyleValue` method from text field adapter as it was unused following the merge of #1911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
getIdleOutlineStyleValuemethod from textfield adapter. AddgetIdleOutlineStyleValuemethod to textfield outline adapter. Updatetests to check new functionality.
BREAKING CHANGE: Text field outline adapter now must implement the
getIdleOutlineStyleValuemethod previously implemented in the text field adapter. The functionality is exactly the same and requires only small changes to accessing the outline node.