From 44f2987053d7b71055ef9229c71d178f3d183d43 Mon Sep 17 00:00:00 2001 From: Andy Dvorak Date: Mon, 11 Feb 2019 17:21:53 -0800 Subject: [PATCH] WIP: Address review comments --- packages/mdc-textfield/icon/foundation.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/mdc-textfield/icon/foundation.ts b/packages/mdc-textfield/icon/foundation.ts index fe25a786703..7a37ce195e1 100644 --- a/packages/mdc-textfield/icon/foundation.ts +++ b/packages/mdc-textfield/icon/foundation.ts @@ -22,11 +22,13 @@ */ import {MDCFoundation} from '@material/base/foundation'; -import {EventType} from '@material/base/index'; +import {SpecificEventListener} from '@material/base/types'; import {MDCTextFieldIconAdapter} from './adapter'; import {strings} from './constants'; -const CLICK_KEYDOWN_EVENTS: EventType[] = ['click', 'keydown']; +type InteractionEventType = 'click' | 'keydown'; + +const INTERACTION_EVENTS: InteractionEventType[] = ['click', 'keydown']; class MDCTextFieldIconFoundation extends MDCFoundation { static get strings() { @@ -51,7 +53,7 @@ class MDCTextFieldIconFoundation extends MDCFoundation } private savedTabIndex_: string | null; - private readonly interactionHandler_: EventListener; + private readonly interactionHandler_: SpecificEventListener; constructor(adapter?: Partial) { super({...MDCTextFieldIconFoundation.defaultAdapter, ...adapter}); @@ -63,13 +65,13 @@ class MDCTextFieldIconFoundation extends MDCFoundation init() { this.savedTabIndex_ = this.adapter_.getAttr('tabindex'); - CLICK_KEYDOWN_EVENTS.forEach((evtType) => { + INTERACTION_EVENTS.forEach((evtType) => { this.adapter_.registerInteractionHandler(evtType, this.interactionHandler_); }); } destroy() { - CLICK_KEYDOWN_EVENTS.forEach((evtType) => { + INTERACTION_EVENTS.forEach((evtType) => { this.adapter_.deregisterInteractionHandler(evtType, this.interactionHandler_); }); } @@ -96,7 +98,7 @@ class MDCTextFieldIconFoundation extends MDCFoundation this.adapter_.setContent(content); } - handleInteraction(evt: Event) { + handleInteraction(evt: MouseEvent | KeyboardEvent) { const isEnterKey = (evt as KeyboardEvent).key === 'Enter' || (evt as KeyboardEvent).keyCode === 13; if (evt.type === 'click' || isEnterKey) { this.adapter_.notifyIconAction();