Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dependencies to MDC Web v1.x.x #829

Closed
wants to merge 38 commits into from

Conversation

moog16
Copy link

@moog16 moog16 commented Apr 30, 2019

fixes #697

gugu and others added 30 commits April 30, 2019 12:10
BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #829 into rc0.12.0 will decrease coverage by 0.66%.
The diff coverage is 92.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.12.0     #829      +/-   ##
============================================
- Coverage     95.14%   94.47%   -0.67%     
============================================
  Files            73       81       +8     
  Lines          2924     3475     +551     
  Branches        449      532      +83     
============================================
+ Hits           2782     3283     +501     
- Misses           46       66      +20     
- Partials         96      126      +30
Impacted Files Coverage Δ
packages/checkbox/NativeControl.tsx 100% <100%> (ø) ⬆️
packages/drawer/AppContent.tsx 66.66% <100%> (ø) ⬆️
packages/select/Option.tsx 100% <100%> (ø)
packages/tab/TabRipple.tsx 100% <100%> (ø) ⬆️
packages/chips/ChipCheckmark.tsx 80% <100%> (ø) ⬆️
packages/dialog/DialogTitle.tsx 100% <100%> (ø) ⬆️
packages/menu/MenuList.tsx 100% <100%> (ø)
packages/card/ActionButtons.tsx 92.3% <100%> (ø) ⬆️
packages/icon-button/index.tsx 97.91% <100%> (ø) ⬆️
packages/dialog/index.tsx 97.9% <100%> (-1.4%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf577d...e9cbd69. Read the comment docs.

@moog16 moog16 closed this May 1, 2019
@moog16 moog16 deleted the feat/mdcweb-typescript-update branch May 8, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use MDC Web Typings
5 participants