Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infrastructure): fix SSR support for webpack4 update #956

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

moog16
Copy link

@moog16 moog16 commented Jun 28, 2019

fixes #954

@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #956 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   94.12%   94.12%           
=======================================
  Files          86       86           
  Lines        3644     3644           
  Branches      576      576           
=======================================
  Hits         3430     3430           
  Misses         90       90           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95ff65...9f0e4eb. Read the comment docs.

@moog16 moog16 merged commit 5d3a89d into master Jul 1, 2019
@moog16 moog16 deleted the fix/ssr-webpack4 branch July 1, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-button 0.14.0 broken in SSR due to window usage
4 participants