Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): Only apply aria-orientation with role #945

Merged

Conversation

liamcmitchell-sc
Copy link
Contributor

Fixes #944

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #945 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   94.12%   94.13%   +<.01%     
==========================================
  Files          86       86              
  Lines        3644     3646       +2     
  Branches      576      578       +2     
==========================================
+ Hits         3430     3432       +2     
  Misses         90       90              
  Partials      124      124
Impacted Files Coverage Δ
packages/list/index.tsx 94.85% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37730b9...81804e6. Read the comment docs.

@dorivaught dorivaught added this to the Sprint 6: June 25-July 8 milestone Jun 25, 2019
Matt Goo and others added 4 commits July 1, 2019 16:56
BREAKING CHANGE:

'orientation` is now used instead of 'aria-orientation' to specify list orientation.
This allows smarter aria defaults that can be overridden if needed.
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please make a few tweaks.

Also are you able to test this in your scenario? Does it work?

@liamcmitchell-sc
Copy link
Contributor Author

Done. Yes, tested this in my project. Works as expected.

@moog16 moog16 changed the base branch from master to rc0.15.0 July 12, 2019 16:10
@moog16 moog16 merged commit beab319 into material-components:rc0.15.0 Jul 12, 2019
@moog16
Copy link

moog16 commented Jul 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants