-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list): Only apply aria-orientation with role #945
fix(list): Only apply aria-orientation with role #945
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 94.12% 94.13% +<.01%
==========================================
Files 86 86
Lines 3644 3646 +2
Branches 576 578 +2
==========================================
+ Hits 3430 3432 +2
Misses 90 90
Partials 124 124
Continue to review full report at Codecov.
|
BREAKING CHANGE: 'orientation` is now used instead of 'aria-orientation' to specify list orientation. This allows smarter aria defaults that can be overridden if needed.
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please make a few tweaks.
Also are you able to test this in your scenario? Does it work?
Done. Yes, tested this in my project. Works as expected. |
Thanks! |
Fixes #944