-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ripple): focus style alive when disabled #943
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #943 +/- ##
============================================
+ Coverage 94.08% 94.08% +<.01%
============================================
Files 86 86
Lines 3634 3637 +3
Branches 572 573 +1
============================================
+ Hits 3419 3422 +3
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
import {withRipple, InjectedProps} from '../../../packages/ripple/index'; | ||
|
||
import Button from '../../../packages/button'; | ||
import {withRipple, InjectedProps} from '../../../packages/ripple'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need this import here? It looks unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is just my habit.
I always separate node_module and local_module imports!
Does it look better to put it back??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstood your comment.
This code already existed before.
import {withRipple, InjectedProps} from '../../../packages/ripple';
I'm just moved it down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! Sorry I didn't notice that. Yes that was there before. Looks good.
Tested this by using part of the stackblitz in the original issue:
Looks like its working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small thing
fixes #916
@poying
I wrote it pretty much like your code.
But I'm not call
handleBlur
and I madedisabledRipplePostProcessor
.Because there are some possibility that adds other code in
handleBlur
.If you have any other opinion, tell me about that!
@moog16
I added
adapter
to a member variable.Existing member variables do not have an
adapter
, is there any special reason??If both of you are okay, I'll write unit test code :)