Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made react a peer dependency for all packages. #940

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

thdk
Copy link
Contributor

@thdk thdk commented Jun 18, 2019

Fixes #616

@moog16 moog16 changed the base branch from master to rc0.14.0 June 18, 2019 21:41
@codecov-io
Copy link

Codecov Report

Merging #940 into rc0.14.0 will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           rc0.14.0     #940     +/-   ##
===========================================
- Coverage     94.08%   93.99%   -0.1%     
===========================================
  Files            86       85      -1     
  Lines          3637     3599     -38     
  Branches        573      568      -5     
===========================================
- Hits           3422     3383     -39     
  Misses           90       90             
- Partials        125      126      +1
Impacted Files Coverage Δ
packages/text-field/index.tsx 97.48% <0%> (-0.79%) ⬇️
packages/tab/index.tsx 95.55% <0%> (-0.05%) ⬇️
packages/list/ListItem.tsx 99.01% <0%> (ø) ⬆️
packages/switch/index.tsx 100% <0%> (ø) ⬆️
packages/text-field/character-counter/index.tsx
packages/top-app-bar/index.tsx 98.26% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7650f...b345dda. Read the comment docs.

@moog16
Copy link

moog16 commented Jun 18, 2019

This is great! Thanks so much - Could you please sign the CLA by commenting "I signed it".

@moog16 moog16 merged commit cc06add into material-components:rc0.14.0 Jun 18, 2019
@thdk
Copy link
Contributor Author

thdk commented Jun 18, 2019

I signed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants