Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/top app bar/deprecate render props #915

Conversation

mgr34
Copy link
Contributor

@mgr34 mgr34 commented Jun 6, 2019

successful merge should close #698.


I signed it.

@moog16 moog16 changed the base branch from rc0.13.0 to rc0.14.0 June 11, 2019 17:49
@moog16
Copy link

moog16 commented Jun 11, 2019

Please update with rc0.14.0 branch

@mgr34 mgr34 force-pushed the refactor/top-app-bar/deprecate-renderProps branch from 6cb311a to 8dc39c9 Compare June 11, 2019 18:01
@codecov-io
Copy link

codecov-io commented Jun 11, 2019

Codecov Report

Merging #915 into rc0.14.0 will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.14.0     #915      +/-   ##
============================================
- Coverage     94.09%   94.08%   -0.02%     
============================================
  Files            86       86              
  Lines          3644     3636       -8     
  Branches        574      573       -1     
============================================
- Hits           3429     3421       -8     
  Misses           90       90              
  Partials        125      125
Impacted Files Coverage Δ
packages/top-app-bar/index.tsx 98.13% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044117f...4394da6. Read the comment docs.

@moog16
Copy link

moog16 commented Jun 11, 2019

@mgr34 I updated rc0.14.0 again. Sorry you will need to push another update

…mponents-web-react into refactor/top-app-bar/deprecate-renderProps
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@mgr34
Copy link
Contributor Author

mgr34 commented Jun 11, 2019

@moog16 no problem. All set. :)

@moog16
Copy link

moog16 commented Jun 11, 2019

Thanks!

@moog16
Copy link

moog16 commented Jun 11, 2019

signed in #915 (comment)

@moog16 moog16 added cla: yes and removed cla: no labels Jun 11, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@moog16 moog16 merged commit 2541ce2 into material-components:rc0.14.0 Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants