-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/top app bar/deprecate render props #915
Refactor/top app bar/deprecate render props #915
Conversation
Please update with rc0.14.0 branch |
6cb311a
to
8dc39c9
Compare
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #915 +/- ##
============================================
- Coverage 94.09% 94.08% -0.02%
============================================
Files 86 86
Lines 3644 3636 -8
Branches 574 573 -1
============================================
- Hits 3429 3421 -8
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
@mgr34 I updated rc0.14.0 again. Sorry you will need to push another update |
…mponents-web-react into refactor/top-app-bar/deprecate-renderProps
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@moog16 no problem. All set. :) |
Thanks! |
signed in #915 (comment) |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
successful merge should close #698.
I signed it.