Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm run lint should fail when there are prettier warnings #902

Closed
moog16 opened this issue Jun 3, 2019 · 0 comments
Closed

npm run lint should fail when there are prettier warnings #902

moog16 opened this issue Jun 3, 2019 · 0 comments

Comments

@moog16
Copy link

moog16 commented Jun 3, 2019

Currently running npm run lint (or fix), will show warnings (not errors). By not throwing errors, the PRs always pass green which has let "unlinted" code into the repo.

Solution: Have npm run lint prettier warnings changed to errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moog16