Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): error with undefined or null children #883

Merged
merged 2 commits into from
May 30, 2019
Merged

fix(chips): error with undefined or null children #883

merged 2 commits into from
May 30, 2019

Conversation

lucasecdb
Copy link
Contributor

@lucasecdb lucasecdb commented May 25, 2019 •
edited
Loading

fixes #880

@codecov-io
Copy link

codecov-io commented May 25, 2019 •
edited
Loading

Codecov Report

Merging #883 into rc0.13.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.13.0     #883      +/-   ##
============================================
+ Coverage        94%   94.01%   +<.01%     
============================================
  Files            85       85              
  Lines          3586     3590       +4     
  Branches        562      564       +2     
============================================
+ Hits           3371     3375       +4     
  Misses           90       90              
  Partials        125      125
Impacted Files Coverage Δ
packages/chips/ChipSet.tsx 98.9% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1b20b...f4d1191. Read the comment docs.

moog16
moog16 approved these changes May 29, 2019
View reviewed changes
Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just one comment.

@moog16 moog16 merged commit d45afbe into material-components:rc0.13.0 May 30, 2019
@moog16 moog16 deleted the fix/undefined-chipset-child branch May 30, 2019 09:16
@moog16 moog16 mentioned this pull request May 30, 2019
Closed
moog16 pushed a commit that referenced this pull request May 30, 2019
@lucasecdb
fix(chips): error with undefined or null children (#883)
d733c29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moog16 moog16 moog16 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasecdb @codecov-io @moog16 @googlebot