Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): make listitem props optional #766

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

moog16
Copy link

@moog16 moog16 commented Mar 22, 2019

related #737
fixes #734

ListItem was missed as the changes were made in the MDC Web v1 typescript update. We moved the list changes out of the latest release, which included making these optional.

@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #766 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #766   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          73       73           
  Lines        2924     2924           
  Branches      449      449           
=======================================
  Hits         2782     2782           
  Misses         46       46           
  Partials       96       96
Impacted Files Coverage Δ
packages/list/ListItem.tsx 97.87% <ø> (ø) ⬆️
packages/ripple/index.tsx 89.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4015bc...63b0ded. Read the comment docs.

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@moog16 moog16 changed the base branch from master to rc0.12.0 March 22, 2019 23:07
@moog16 moog16 merged commit ffd7776 into rc0.12.0 Mar 25, 2019
@moog16 moog16 deleted the fix/listitem/make-props-optional branch March 25, 2019 19:50
moog16 pushed a commit that referenced this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS props required when should be optional
4 participants