Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): null check for checkmark ref #677

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

moog16
Copy link

@moog16 moog16 commented Feb 14, 2019

fixes chips when filter chips are unmounted. setCheckmarkWidth ref method is called, but checkmark is null.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   94.83%   94.83%           
=======================================
  Files          67       67           
  Lines        2768     2768           
  Branches      414      414           
=======================================
  Hits         2625     2625           
  Misses         50       50           
  Partials       93       93
Impacted Files Coverage Δ
packages/chips/ChipSet.tsx 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788b426...e939e44. Read the comment docs.

@moog16 moog16 merged commit 2d22f85 into master Feb 14, 2019
@moog16 moog16 deleted the fix/chip-filter-unmounting branch February 14, 2019 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants