Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): clientHeight unit test #668

Merged
merged 2 commits into from Feb 12, 2019
Merged

fix(test): clientHeight unit test #668

merged 2 commits into from Feb 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2019

I originally tried to fix another issue, but there was a problem with the test code.
Height varies depending on browser.
For example, height is "19" in my browser.
So I compare it with real DOM's height.

Please check :)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ghost
Copy link
Author

ghost commented Feb 10, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

codecov-io commented Feb 10, 2019

Codecov Report

Merging #668 into rc0.10.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.10.0     #668   +/-   ##
=========================================
  Coverage     94.81%   94.81%           
=========================================
  Files            68       68           
  Lines          2852     2852           
  Branches        431      431           
=========================================
  Hits           2704     2704           
  Misses           51       51           
  Partials         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7563dff...8961036. Read the comment docs.

@moog16
Copy link

moog16 commented Feb 12, 2019

@TroyTae can you please merge rc0.10.0 branch into your branch and push? It'll kick off the tests

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@ghost
Copy link
Author

ghost commented Feb 12, 2019

@moog16
I complete to merge with rc0.10.0 branch.
Should I do this my every PR in the future?

@moog16
Copy link

moog16 commented Feb 12, 2019

@TroyTae yes please merge to the latest rcX.0 branch. Next will be rc0.11.0

@moog16 moog16 changed the base branch from master to rc0.10.0 February 12, 2019 19:28
@moog16 moog16 merged commit 457afee into material-components:rc0.10.0 Feb 12, 2019
@moog16
Copy link

moog16 commented Feb 12, 2019

merged - signed in #668 (comment). PR tests passin gin #673

moog16 pushed a commit that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants