-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): clientHeight unit test #668
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #668 +/- ##
=========================================
Coverage 94.81% 94.81%
=========================================
Files 68 68
Lines 2852 2852
Branches 431 431
=========================================
Hits 2704 2704
Misses 51 51
Partials 97 97 Continue to review full report at Codecov.
|
@TroyTae can you please merge rc0.10.0 branch into your branch and push? It'll kick off the tests |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@moog16 |
@TroyTae yes please merge to the latest rcX.0 branch. Next will be rc0.11.0 |
merged - signed in #668 (comment). PR tests passin gin #673 |
I originally tried to fix another issue, but there was a problem with the test code.
Height varies depending on browser.
For example, height is "19" in my browser.
So I compare it with real DOM's height.
Please check :)