-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Windows development #662
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #662 +/- ##
========================================
Coverage 94.8% 94.8%
========================================
Files 68 68
Lines 2849 2849
Branches 429 429
========================================
Hits 2701 2701
Misses 51 51
Partials 97 97 Continue to review full report at Codecov.
|
This reverts commit d3b4b7a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening! Changes look good - I'll have to test myself on a windows machine.
Did you also test the screenshot tests on Docker?
I did not test the screenshots on Docker, the changes made were to get the
`npm run test:unit` to work first
I ran into other problems when trying to get this project setup on my
windows machine. `npm install/ci` is failing as well. I can log an issue
for that if you want.
…On Fri, 8 Feb 2019 at 07:11, Matt Goo ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for opening! Changes look good - I'll have to test myself on a
windows machine.
Did you also test the screenshot tests on Docker?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#662 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABFkvd5bnqBMaGAi--Qg8WUQpRiZnDIoks5vLJaBgaJpZM4amjJu>
.
|
gotcha - nope this is better than nothing :) |
tests pr #664 |
@madaz please sign this PR |
I signed it! |
Enable development on windows environment.
Replace non-windows commands for npm cross environment packages.
rimraf
replaces therm
commandcross-env
for setting environment variables@moog16