Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Windows development #662

Merged
merged 5 commits into from
Feb 8, 2019
Merged

(fix) Windows development #662

merged 5 commits into from
Feb 8, 2019

Conversation

madaz
Copy link
Contributor

@madaz madaz commented Feb 7, 2019

Enable development on windows environment.

Replace non-windows commands for npm cross environment packages.

  • rimraf replaces the rm command
  • cross-env for setting environment variables

@moog16

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #662 into rc0.10.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           rc0.10.0    #662   +/-   ##
========================================
  Coverage      94.8%   94.8%           
========================================
  Files            68      68           
  Lines          2849    2849           
  Branches        429     429           
========================================
  Hits           2701    2701           
  Misses           51      51           
  Partials         97      97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d141be1...71adab1. Read the comment docs.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening! Changes look good - I'll have to test myself on a windows machine.

Did you also test the screenshot tests on Docker?

@madaz
Copy link
Contributor Author

madaz commented Feb 7, 2019 via email

@moog16 moog16 changed the base branch from master to rc0.10.0 February 8, 2019 15:48
@moog16
Copy link

moog16 commented Feb 8, 2019

gotcha - nope this is better than nothing :)

@moog16
Copy link

moog16 commented Feb 8, 2019

tests pr #664

@moog16
Copy link

moog16 commented Feb 8, 2019

@madaz please sign this PR

@madaz
Copy link
Contributor Author

madaz commented Feb 8, 2019

I signed it!

@moog16 moog16 merged commit 802066a into material-components:rc0.10.0 Feb 8, 2019
moog16 pushed a commit that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants