Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): copy selectedChipIds before calling setState #645

Merged
merged 6 commits into from
Jan 30, 2019

Conversation

moog16
Copy link

@moog16 moog16 commented Jan 29, 2019

fixes #644

gugu and others added 5 commits January 25, 2019 23:29
Fix default classes

WIP correct implementation of announce method

Change modile name, onAnnounce event, handling keydown

Add missing methods, unit tests

Minimal screenshot tests

Leading/stacked tests

React-snackbar example

ESLint

Improve quality of react-snackbar (quick fixes)

Add comments for snackbar test css hack, standard callback names in props

Add TODO for updating types from mdc-snackbar when possible

Added docs for announce, version 0.0.0, typescript lint fixes

Adapter tests, moved mdc-snackbar to classes attribute

Achieve 100% test coverage

Revert karma changes

Getting snackbar parameters docs
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@codecov-io
Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #645 into rc0.10.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.10.0     #645   +/-   ##
=========================================
  Coverage     94.87%   94.87%           
=========================================
  Files            68       68           
  Lines          2831     2831           
  Branches        426      426           
=========================================
  Hits           2686     2686           
  Misses           50       50           
  Partials         95       95
Impacted Files Coverage Δ
packages/chips/ChipSet.tsx 98.64% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0e8b6...9551e16. Read the comment docs.

@moog16 moog16 merged commit 4642324 into rc0.10.0 Jan 30, 2019
@moog16 moog16 deleted the fix/chip/propshandleselect branch January 30, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants