-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chips): copy selectedChipIds before calling setState #645
Conversation
Fix default classes WIP correct implementation of announce method Change modile name, onAnnounce event, handling keydown Add missing methods, unit tests Minimal screenshot tests Leading/stacked tests React-snackbar example ESLint Improve quality of react-snackbar (quick fixes) Add comments for snackbar test css hack, standard callback names in props Add TODO for updating types from mdc-snackbar when possible Added docs for announce, version 0.0.0, typescript lint fixes Adapter tests, moved mdc-snackbar to classes attribute Achieve 100% test coverage Revert karma changes Getting snackbar parameters docs
…mponents-web-react into rc0.10.0
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #645 +/- ##
=========================================
Coverage 94.87% 94.87%
=========================================
Files 68 68
Lines 2831 2831
Branches 426 426
=========================================
Hits 2686 2686
Misses 50 50
Partials 95 95
Continue to review full report at Codecov.
|
fixes #644