Do not import constants from @material/textfield internals #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #639 +/- ##
=========================================
Coverage 94.83% 94.83%
=========================================
Files 67 67
Lines 2768 2768
Branches 414 414
=========================================
Hits 2625 2625
Misses 50 50
Partials 93 93
Continue to review full report at Codecov.
|
moog16
approved these changes
Jan 29, 2019
This line imports constants module not from @material/textfield/dist, but from original source code
```
import {VALIDATION_ATTR_WHITELIST} from '@material/textfield/constants';
```
`@material/textfield/constants` is written in Babel language (I don't know how to call it) and contains babel export construction. If someone tries to use textfield from node.js test, it will fail
It is regression as it worked for version 0.7.0
moog16
pushed a commit
that referenced
this pull request
Jan 30, 2019
moog16
pushed a commit
that referenced
this pull request
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line imports constants module not from @material/textfield/dist, but from original source code
@material/textfield/constantsis written in Babel language (I don't know how to call it) and contains babel export construction. If someone tries to use textfield from node.js test, it will failIt is regression as it worked for version 0.7.0