Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screenshot-uploads bucket public for read #635

Closed
gugu opened this issue Jan 25, 2019 · 5 comments
Closed

Make screenshot-uploads bucket public for read #635

gugu opened this issue Jan 25, 2019 · 5 comments

Comments

@gugu
Copy link
Contributor

gugu commented Jan 25, 2019

There is nothing secret (I think) in this folder

If all files there will be public, I can update npm run test:image-diff and travis.yml file to download files from this bucket using public URL if there is no MDC_GCLOUD_SERVICE_ACCOUNT_KEY present.

It will make tests for pull requests to be green if no golden files changed. And as soon as maintainer uploads the new golden - pull requests will become green as well

For the repository tests will run as usual because it has MDC_GCLOUD_SERVICE_ACCOUNT_KEY set for travis

@moog16
Copy link

moog16 commented Jan 25, 2019

@gugu
Copy link
Contributor Author

gugu commented Jan 28, 2019

Thanks. Created #638

@moog16
Copy link

moog16 commented Jan 28, 2019

closing. looks like it is working..this saves a ton of time!

@moog16
Copy link

moog16 commented Jan 28, 2019

Sorry - I jumped the gun on closing this. I'll review #638

@moog16 moog16 reopened this Jan 28, 2019
@gugu
Copy link
Contributor Author

gugu commented Jan 29, 2019

Thanks

@gugu gugu closed this as completed Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants