-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make screenshot-uploads bucket public for read #635
Comments
@gugu can you try now? https://console.cloud.google.com/storage/browser/screenshot-uploads |
Thanks. Created #638 |
closing. looks like it is working..this saves a ton of time! |
Sorry - I jumped the gun on closing this. I'll review #638 |
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is nothing secret (I think) in this folder
If all files there will be public, I can update
npm run test:image-diff
andtravis.yml
file to download files from this bucket using public URL if there is noMDC_GCLOUD_SERVICE_ACCOUNT_KEY
present.It will make tests for pull requests to be green if no golden files changed. And as soon as maintainer uploads the new golden - pull requests will become green as well
For the repository tests will run as usual because it has
MDC_GCLOUD_SERVICE_ACCOUNT_KEY
set for travisThe text was updated successfully, but these errors were encountered: