Remove scss extensions from @material/mdc-* imports

[johnelliott]

Hi, I would like to help with material-components-web-react.

The sass imports are handy, but I was having trouble importing SCSS from Button. I needed to directly import the css from the non-react package, basically duplicating the intent of the index.scss of react-button:

When I looked at the icon component sass import I noticed that it didn't have an extension. Going into node_modules and removing it from the button index.scss file fixed the issue and allowed me to just import the button styles with @import "@material/button/mdc-button";, so perhaps this was just an oversight.

I've never used learn before, so I may need help figuring out how to contribute to this codebase :/

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[johnelliott]

I signed it!

[googlebot]

CLAs look good, thanks!

[moog16]

@johnelliott Thanks for opening the PR. You're right it's not necessary and we can remove the extension from the filename. Can you also remove it from card, floating-label, line-ripple, and text-field Sass files for consistency?

Also something I realize is that you do not have the creds for the screenshot tests. I pushed a commit to see if it works for me.

[johnelliott]

@moog16 thanks Matt. I like this lib; want to show my support :)

I'll update too.

[johnelliott]

Is it OK to add line-ripple, floating-label to the allowed scopes for commit messages?

[codecov-io]

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          18       18           
  Lines         607      607           
  Branches       49       49           
=======================================
  Hits          602      602           
  Misses          5        5

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 203cf34...209a6b0. Read the comment docs.

[johnelliott]

Perhaps this test failure is also permissions-related for the screenshot job.

[moog16]

RE allowed scopes: YES definitely

RE Testing: Looking into Docker. Might be able to help us here.

[johnelliott]

Ok, I use Docker and maybe that'd be the easiest way to get many people up and running those tests. I would be OK helping to set that up but I'd need initial direction.

[moog16]

@johnelliott I think you're right, but I'm not sure why. Maybe its because you're out of the org? I will look into this. But I'll accept the changes.

[moog16]

Opened this issue concerning tests: #71. I'm just gonna run the tests locally and merge this for you. Thanks!

[johnelliott]

Thanks @moog16