fix(infrastructure): condense webpack configuration build step into one json file #571
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Codecov Report
@@ Coverage Diff @@
## rc0.8.0 #571 +/- ##
========================================
Coverage 94.71% 94.71%
========================================
Files 61 61
Lines 2554 2554
Branches 365 365
========================================
Hits 2419 2419
Misses 50 50
Partials 85 85Continue to review full report at Codecov.
|
| ), | ||
| module: { | ||
| rules: [{ | ||
| test: /\.ts(x)?$/, | ||
| loader: 'ts-loader', | ||
| }, { |
There was a problem hiding this comment.
this was here before, but i realized we need it back, since we do still reference .js files
|
CLAs look good, thanks! |
| @@ -17,10 +16,5 @@ | |||
| "exclude": [ | |||
| "node_modules", | |||
| "build" | |||
| ], | |||
| "baseUrl": ".", | |||
There was a problem hiding this comment.
the repo still works without this
| @@ -2,7 +2,6 @@ | |||
| "extends": "gts/tsconfig-google.json", | |||
| "compilerOptions": { | |||
| "outDir": "./types/", | |||
| "declaration": true, | |||
There was a problem hiding this comment.
Is this used to generate the .d.ts files ?
There was a problem hiding this comment.
Yes but its included in gts/tsconfig-google
…ne json file (#571) BREAKING CHANGE: Remove <package-name>.es.js files. The alternate is now to use the index.tsx files.
…ne json file (#571) BREAKING CHANGE: Remove <package-name>.es.js files. The alternate is now to use the index.tsx files.
The change to ts-loader increased the amount of memory the webpack config needed. Changing the webpack config to use the multiple entries pattern allows webpack to perform a lot faster.
BREAKING CHANGE: Remove
<package-name>.es.jsfiles. The alternate is now to use theindex.tsxfiles.