-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(top-app-bar): TopAppBarFixedAdjust variants added #524
feat(top-app-bar): TopAppBarFixedAdjust variants added #524
Conversation
Codecov Report
@@ Coverage Diff @@
## rc0.8.0 #524 +/- ##
===========================================
+ Coverage 96.62% 96.63% +0.01%
===========================================
Files 59 59
Lines 1984 1991 +7
Branches 235 239 +4
===========================================
+ Hits 1917 1924 +7
Misses 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening PR! Just a few changes.
tests: #538 |
Test passing and CLA signed in: #524 (comment) merging! |
This references #518 and can be closed with the previous merging of PR #520.
I am still unsure about screenshot testing. running
yarn capture
did update the correct part's ofgolden.json
and everything appears as expected fromyarn start
.I signed it