fix(select): added check for nativeControl element before calling props.setRippleCenter in NativeControl #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
props.setRippleCenter in NativeControl
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 96.67% 96.62% -0.06%
==========================================
Files 59 59
Lines 1984 1984
Branches 234 235 +1
==========================================
- Hits 1918 1917 -1
- Misses 66 67 +1
Continue to review full report at Codecov.
|
bonniezhou
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #476
This fixes the issue by only calling
NativeControl.props.setRippleCenter()when it is the native element. Potential Issues: A developer cannot access the native element via a ref. However this was already an issue before. Getting this feature would be a new feature and a different PR.