feat(radio): add component #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc7.0 #448 +/- ##
==========================================
+ Coverage 96.56% 96.65% +0.09%
==========================================
Files 57 59 +2
Lines 1923 1975 +52
Branches 226 232 +6
==========================================
+ Hits 1857 1909 +52
Misses 66 66
Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Nov 15, 2018
packages/radio/NativeControl.js
Outdated
|
|
||
| const NativeControl = (props) => { | ||
| const { | ||
| setRippleActivator, |
There was a problem hiding this comment.
can we replace this with rippleActivatorRef similar to how it is in Checkbox?
packages/radio/index.js
Outdated
| const children = React.Children.only(this.props.children); | ||
| const updatedProps = Object.assign({}, children.props, { | ||
| disabled: this.state.disabled, | ||
| setRippleActivator: this.setRippleActivator, |
There was a problem hiding this comment.
we can pass the rippleActivator as a ref directly to NativeControl (see comment above)
bonniezhou
approved these changes
Nov 17, 2018
packages/radio/index.js
Outdated
| } | ||
|
|
||
| setRippleActivator = (element) => this.rippleActivator = element; | ||
| // setRippleActivator = (element) => this.rippleActivator = element; |
moog16
pushed a commit
that referenced
this pull request
Nov 20, 2018
moog16
pushed a commit
that referenced
this pull request
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #157