Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawer - replace focus-trap with vanilla version #433

Closed
moog16 opened this issue Nov 13, 2018 · 0 comments
Closed

drawer - replace focus-trap with vanilla version #433

moog16 opened this issue Nov 13, 2018 · 0 comments
Assignees
@moog16
Milestone
0.7.0

Comments

@moog16
Copy link

moog16 commented Nov 13, 2018

Currently the modal drawer uses https://github.com/davidtheclark/focus-trap-react. This causes several issues:

  1. when the modal closes, the children of the modal loses state (seen in fix(drawer): screenshots use list #432)
  2. can crash an application if none of the items in the drawer are "focusable" (Modal variant of drawer crashes React over uncaught exception in FocusTrap #382)

I propose using https://github.com/davidtheclark/focus-trap instead of the react wrapper. It seems to work in the MDC Web version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moog16 moog16

Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@moog16