fix(layout-grid): remove unit test console warnings #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add child elements to `Grid` and `Row` test wrappers
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 51 51
Lines 1823 1823
Branches 211 211
=======================================
Hits 1766 1766
Misses 57 57Continue to review full report at Codecov.
|
|
Nice thanks so much! I was gonna do that so you saved me. |
|
please can you add the "I signed it!" comment on this PR. Once #384 passes, we can merge |
|
tests are passing: #384 @hvolschenk please comment "I signed it" when you get a chance. |
|
I signed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the tests this morning for the typography package and saw I left console warnings behind the previous time.
I now cleaned up after myself :)