fix(top-app-bar): allow react elements in title #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 51 51
Lines 1823 1823
Branches 211 211
=======================================
Hits 1767 1767
Misses 56 56
Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Oct 30, 2018
There was a problem hiding this comment.
Putting a node as label for Text Field messes up its positioning... I'm guessing this has to do with the MDC Web calculations around the width/position/size of the label. I'd suggest we keep this PR for Top App Bar and file a separate bug for allowing node prop in Text Field
|
created #388 |
bonniezhou
approved these changes
Nov 5, 2018
4cm4k1
added a commit
to 4cm4k1/material-components-web-react
that referenced
this pull request
Nov 6, 2018
…ial-components-web-react into fix/list/allow-alternate-tags * 'master' of https://github.com/material-components/material-components-web-react: docs(menu-surface): open state & ref errors (material-components#412) fix(text-field): allow for input isValid override (material-components#374) feat(list): Add List Group and List Group Subheader (material-components#386) fix(top-app-bar): allow react elements in title (material-components#376) docs: update main component manifest on main Readme (material-components#394) docs: update roadmap (material-components#396) docs: Add web survey link in readmes (material-components#402) docs: update main README with CRA2 guidelines (material-components#393)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #253