Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(top-app-bar): add fixed adjust component #349

Merged
merged 10 commits into from
Oct 23, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Oct 17, 2018

fixes #348

@codecov-io
Copy link

codecov-io commented Oct 17, 2018

Codecov Report

Merging #349 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   97.25%   97.25%   +<.01%     
==========================================
  Files          36       37       +1     
  Lines        1491     1496       +5     
  Branches      164      164              
==========================================
+ Hits         1450     1455       +5     
  Misses         41       41
Impacted Files Coverage Δ
packages/top-app-bar/index.js 100% <ø> (ø) ⬆️
packages/top-app-bar/FixedAdjust.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3bffc...4283c74. Read the comment docs.

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to a screenshot test?

@moog16
Copy link
Author

moog16 commented Oct 17, 2018

definitely!

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moog16 moog16 merged commit f1d4be0 into master Oct 23, 2018
@moog16 moog16 deleted the fix/top-app-bar/add-fixed-adjust-component branch October 23, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants