feat: Add roses example #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 36 36
Lines 1491 1491
Branches 164 164
=======================================
Hits 1450 1450
Misses 41 41Continue to review full report at Codecov.
|
bonniezhou
suggested changes
Oct 16, 2018
examples/roses/README.md
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Roses Example | |||
|
|
|||
| This is an example of a product feedback form using only MDC React components. This also uses some MDC Web-only packages, which are just styles ([typography](https://github.com/material-components/material-components-web/tree/master/packages/mdc-typography), [theme]https://github.com/material-components/material-components-web/tree/master/packages/mdc-theme, and [shape](https://github.com/material-components/material-components-web/tree/master/packages/mdc-shape)). | |||
There was a problem hiding this comment.
missing a bracket after theme
examples/roses/README.md
Outdated
|
|
||
| 1. `cd ./examples/roses` | ||
| 1. `npm i` | ||
| 1. `npk start` |
examples/roses/Feedback.js
Outdated
| import Button from '@material/react-button'; | ||
| import MaterialIcon from '@material/react-material-icon'; | ||
|
|
||
| import './index.scss'; |
There was a problem hiding this comment.
unnecessary since it's already imported in index.js
|
|
||
| class Feedback extends React.Component { | ||
| state = { | ||
| feedback: '', |
There was a problem hiding this comment.
Suggested change
| feedback: '', | |
| feedback: '', | |
| feedbackChips: [], |
There was a problem hiding this comment.
Add selected chips to state too
examples/roses/Feedback.js
Outdated
| alt='red roses logo' | ||
| /> | ||
| {this.renderMessage()} | ||
| <ChipSet filter> |
There was a problem hiding this comment.
Suggested change
| <ChipSet filter> | |
| <ChipSet | |
| filter | |
| selectedChipIds={this.state.feedbackChips} | |
| handleSelect={(selectedChipIds) => this.setState({feedbackChips: selectedChipIds})} | |
| > |
|
Also want to add analytics |
|
Don't think I can add analytics to a not-live site |
|
Also added note to readme about being on node v10.4.x |
bonniezhou
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to use more of our components, testing/dogfooding, and show casing, I started with this product feedback page using text field, top app bar, chips, and button.