Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips): add chip leading icon class management #281

Merged
merged 9 commits into from
Sep 25, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Sep 24, 2018

fixes #270

@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #281 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.02%     
==========================================
  Files          33       33              
  Lines        1275     1289      +14     
  Branches      125      126       +1     
==========================================
+ Hits         1242     1256      +14     
  Misses         33       33
Impacted Files Coverage Δ
packages/chips/Chip.js 97.29% <100%> (+0.52%) ⬆️
packages/chips/ChipSet.js 98.59% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8435079...1da8d88. Read the comment docs.

Copy link
Contributor

@bonniezhou bonniezhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading icon is missing some transitions. I think we'll have to use a ref similar to #273, since the leading icon transition depends on requestAnimationFrame

@moog16 moog16 merged commit c638e79 into master Sep 25, 2018
@moog16 moog16 deleted the fix/chip/add-leading-icon-class branch September 25, 2018 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants