fix: tab indicator sliding animation broken #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 97.21% 97.21% -0.01%
==========================================
Files 33 33
Lines 1258 1257 -1
Branches 120 122 +2
==========================================
- Hits 1223 1222 -1
Misses 35 35
Continue to review full report at Codecov.
|
bonniezhou
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the update to MDC Web 0.39.x, the tab indicator's default sliding animation stopped working. The cause was from removing the requestAnimationFrame from MDC Web code. Since the React component's classes were originally managed by setState, which is async, this didn't give the browser enough time to apply the classes. This ultimately broke the animation.
This fix is to use the DOM's classList, which is synchronous. This requires us to use a
forceUpdate, which is not used in our codebase. But since this animation requires synchronous class management, we need to forceUpdate after adding/removing classes.