Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ripple): react-ripple does not contain styles (#172) #251

Merged
merged 3 commits into from
Aug 28, 2018

Conversation

bmihelac
Copy link
Contributor

No description provided.

@bmihelac
Copy link
Contributor Author

Not sure why travis screesnshots tests are failing but, I notice that they are also failing with documentation update from #250

@moog16
Copy link

moog16 commented Aug 28, 2018

@bmihelac screenshot tests from external developers are flaky. I'm not sure why either, and it requires some investigation on our part (we have an issue open).

Thanks for fixing this issue as well!

fixes #172

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          23       23           
  Lines         969      969           
  Branches       98       98           
=======================================
  Hits          958      958           
  Misses         11       11
Impacted Files Coverage Δ
packages/text-field/index.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9eb8ca...d482689. Read the comment docs.

@moog16 moog16 mentioned this pull request Aug 28, 2018
@moog16
Copy link

moog16 commented Aug 28, 2018

Tests passing #252

@moog16 moog16 merged commit ac0f87f into material-components:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants