-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tab-indicator): update component to work with mdc tab #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
+ Coverage 98.78% 98.8% +0.01%
=========================================
Files 21 21
Lines 824 834 +10
Branches 76 78 +2
=========================================
+ Hits 814 824 +10
Misses 10 10
Continue to review full report at Codecov.
|
packages/tab-indicator/index.scss
Outdated
@@ -1 +1,6 @@ | |||
@import "@material/tab-indicator/mdc-tab-indicator"; | |||
|
|||
.mdc-tab-indicator__content--icon .material-icons { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont do this. Instead make the material-icons stylesheet load before the mdc-tab-indicator stylesheet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the .material-icons
class has the font-size: 24px. So rearranging the stylesheets will not help here.
I moved the logic around so that we now have the ref on the TabIndicatorElement. We then use .getElementsByClassName, which I think is fine in this case. The call is scoped to just the tabIndicator.
--active
class--active
class--icon .material-icons
element. Since .material-icons has a 24px font-size