feat(tab-indicator): add new component #202
Conversation
packages/tab-indicator/README.md
Outdated
| @@ -0,0 +1,80 @@ | |||
| # React Ripple | |||
packages/tab-indicator/index.js
Outdated
| get contentClasses() { | ||
| const {contentClassName, icon} = this.props; | ||
| return classnames('mdc-tab-indicator__content', contentClassName, { | ||
| 'mdc-tab-indicator__content--icon': icon, |
There was a problem hiding this comment.
this is fine for now
But will you file a bug on MDCW to NOT put modifier classes on sub elements? I think this should have been mdc-tab-indicator--icon and mdc-tab-indicator--underline...but we missed it in the review
| handleTransitionEnd = (e) => { | ||
| this.props.onTransitionEnd(e); | ||
|
|
||
| if (!this.allowTransitionEnd_) return; |
There was a problem hiding this comment.
can you file a bug in MDCW to remove the register/deregister pattern? And leave a note here to update MDCR once that bug is fixed in MDCW
There was a problem hiding this comment.
I opened this material-components/material-components-web#3279, but all other components are being tracked in this issue
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 98.69% 98.78% +0.08%
==========================================
Files 20 21 +1
Lines 768 821 +53
Branches 69 76 +7
==========================================
+ Hits 758 811 +53
Misses 10 10
Continue to review full report at Codecov.
|
fixes #149