Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infrastructure): point all tests to es6 files for accurate test coverage #198

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Jul 31, 2018

Test coverage was inaccurate (and very low), since the coverage framework was looking at the package.json main files.

This PR changes the test files to only import from ES6 files. It also performs an npm run clean before running the unit tests. This will force istanbul to use the index.js ES6 files instead.

Before and after pics attached:

screenshot from 2018-07-31 13-56-59
screenshot from 2018-07-31 14-35-15

@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #198 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          18       18           
  Lines         661      661           
  Branches       62       62           
=======================================
  Hits          653      653           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10157f8...8d9a912. Read the comment docs.

@moog16 moog16 merged commit 4959266 into master Aug 1, 2018
@moog16 moog16 deleted the fix/testing-coverage-report branch August 1, 2018 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants