Skip to content

Commit

Permalink
fix(checkbox): add focusable=false to svg for a11y (#375)
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt Goo authored Oct 30, 2018
1 parent dac1ecf commit c7f3b97
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion packages/checkbox/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,9 @@ export class Checkbox extends Component {
/>
<div className='mdc-checkbox__background'>
<svg className='mdc-checkbox__checkmark'
viewBox='0 0 24 24'>
viewBox='0 0 24 24'
focusable='false'
>
<path className='mdc-checkbox__checkmark-path'
fill='none'
d='M1.73,12.91 8.1,19.28 22.79,4.59'/>
Expand Down
2 changes: 1 addition & 1 deletion packages/chips/ChipCheckmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default class ChipCheckmark extends Component {
render() {
return (
<div className='mdc-chip__checkmark' ref={this.init}>
<svg className='mdc-chip__checkmark-svg' viewBox='-2 -3 30 30'>
<svg className='mdc-chip__checkmark-svg' viewBox='-2 -3 30 30' focusable='false'>
<path
className='mdc-chip__checkmark-path'
fill='none'
Expand Down
2 changes: 1 addition & 1 deletion packages/notched-outline/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default class NotchedOutline extends React.Component {
className={this.classes}
key='notched-outline'
ref={this.outlineElement_}>
<svg>
<svg focusable='false'>
<path ref={this.pathElement_}
className='mdc-notched-outline__path' />
</svg>
Expand Down

0 comments on commit c7f3b97

Please sign in to comment.