Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #997

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #997

wants to merge 4 commits into from

Conversation

iirk1
Copy link

@iirk1 iirk1 commented Oct 12, 2024

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add a favicon on the page
image
  1. Fix width for these blocks
image
  1. The width must be are same everywhere and add hover effects here
image
  1. Add hover effects for all clickable elements
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!
To improve:

  1. Make all these fields are required before sending
image
  1. Open these additional links in the new tab
image
  1. These links must be lead to the relevant sections and add scroll behavior smooth on the page
image image
  1. Remove max width for these blocks, use 100% instead
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
You need to implement the menu when user clicks here
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants