Develop #643
Open
Develop #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim2310
suggested changes
Aug 1, 2023
There was a problem hiding this comment.
Good job!!!
but lets make some improves:
- hover on change theme buttons make other block jumping and other nav link haven't hover effects
https://www.loom.com/share/8eb6cc5167944e348b0a7edfa8249398 - your container and break points are so huge
3.add hover effect on phone number and browser must to initiate a call after click on it
- user dont know what is must to fill in, add placeholder like in design and when i try to send a form, it must to clear they fields
- footer link also must have hover
- blocks must to take all available place
|
about third point, I can't understand why placeholder doesn't display after deploy( in local deploy it is successfully displays |
maxim2310
suggested changes
Aug 8, 2023
There was a problem hiding this comment.
You made a nice work, but still have to fix a couple of thingth
1.https://www.loom.com/share/d18d894061344331825b9b8f3c98b780
2. i think content must to take a bit more places
3.add link to home on logo icon
4 and would be better to add link on social icon (with target = _blanc)
maxim2310
suggested changes
Aug 10, 2023
agniya-i
suggested changes
Aug 10, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
Dia landing