Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change match computing and notification functionality #28

Open
3 of 4 tasks
MJDeligan opened this issue Sep 9, 2022 · 2 comments
Open
3 of 4 tasks

Change match computing and notification functionality #28

MJDeligan opened this issue Sep 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@MJDeligan
Copy link
Collaborator

MJDeligan commented Sep 9, 2022

The current idea is:

  • The event ends
  • The organizer sets a delay
  • Matches are computed
  • User's are notified after the delay

The problem is that users would be able to see matches before the delay, because we are only delaying the messaging and not the computing. This would require more tables and cron jobs to orchestrate.

Instead we will have organizers manually compute and publish the results, so we will need to:

  • Remove the delay set on events
  • Add a function that computes matches and then sends the notifications via edge functions
  • Add the required UI and logic to the frontend for organizers after they end the event
  • Remind organizers if they haven't published the results after some time

We probably won't use the notifications table for this anymore, because we create and then immediately send and discard the notifications, so we might as well just use a temp table.

Maybe we should add some indicator to events whether the results have been published or not, so that users aren't confused about whether they should be seeing their matches for an event or not.

To remind organizers we could add an end timestamp to events, which is computed when the event is actually ended. That way we know how much time has passed, since the end of the event and can show a reminder in the app after X hours or have a cron-job running that reminds organizers via email after at least X hours have passed.

@sueszli
Copy link
Member

sueszli commented Sep 9, 2022

Woah this is a great description :)
[reminder to myself to update the mockups accordingly]

@sueszli
Copy link
Member

sueszli commented Oct 11, 2022

Missing feature / enhancement that we could add in the future: Reminding the organizers if they didn't publish the matches after a while (otherwise this feature is implemented as described above)

@sueszli sueszli added the enhancement New feature or request label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants