Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] scripts for running schema migrations should run ALL migrations available #72

Open
masukomi opened this issue Aug 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers important

Comments

@masukomi
Copy link
Owner

currently the scripts/bash_helpers/migrations.sh bash helper script can find and run the next schema migration, but won't run all of the pending ones if the user is upgrading across multiple versions.

for example:

If you're on schema version 1 and there are migrations for version 2 & 3 it will only run the one for version 2

Desired behavior

If you're on schema version 1 and there are migrations for version 2 & 3 it will run the migration for 2 & then the migration for 3

Implementation thoughts

I'm imagining something like a run_migrations function with a while loop in it that keeps calling run_next_migration_file_if_present and incrementing a number until there's no more migrations to run. That's not quite how it'll work, but something along those lines.

@masukomi masukomi added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2024
@masukomi masukomi added this to the v2.2 milestone Aug 19, 2024
@masukomi masukomi removed this from the v2.2 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers important
Projects
None yet
Development

No branches or pull requests

1 participant