fix: use correct module when using multiple modules versions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastilver
changed the title
mastilver
force-pushed
the
fix-multiple-version-loaded
branch
from
5c7fb99
to
8915d57
Compare
|
@fedeoo I took your original commit from #21 , added some tests and refactored it a bit |
mastilver
force-pushed
the
fix-multiple-version-loaded
branch
from
8915d57
to
cd4f909
Compare
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
+ Coverage 98.64% 98.75% +0.1%
=========================================
Files 1 1
Lines 74 80 +6
=========================================
+ Hits 73 79 +6
Misses 1 1
Continue to review full report at Codecov.
|
mastilver
commented
Jul 19, 2017
src/index.js
Outdated
| @@ -72,6 +73,11 @@ export default class ModulesCdnWebpackPlugin { | |||
|
|
|||
| const {version, peerDependencies} = readPkgUp({cwd: resolvePkg(modulePath, {cwd: contextPath})}).pkg; | |||
|
|
|||
| const isAnotherVersionOfModuleLoaded = this.modulesFromCdn[modulePath] && this.modulesFromCdn[modulePath].version !== version; | |||
| if (isAnotherVersionOfModuleLoaded) { | |||
There was a problem hiding this comment.
Should exit early if module with the same version is already loaded
mastilver
force-pushed
the
fix-multiple-version-loaded
branch
from
cd4f909
to
4ca5dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.