From 3440e32237d821c372fb081eec5fdd04d4d1a22e Mon Sep 17 00:00:00 2001 From: Tom Fleming Date: Fri, 25 Sep 2020 16:56:36 -0400 Subject: [PATCH 1/2] Fixed Firefox-specific JS that was causing overlay issues - DP-20055 --- .../styleguide/source/assets/js/modules/mainNavHamburger.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/patternlab/styleguide/source/assets/js/modules/mainNavHamburger.js b/patternlab/styleguide/source/assets/js/modules/mainNavHamburger.js index f8ab7a75d7..ae51c3915a 100644 --- a/patternlab/styleguide/source/assets/js/modules/mainNavHamburger.js +++ b/patternlab/styleguide/source/assets/js/modules/mainNavHamburger.js @@ -713,11 +713,7 @@ function commonOpenMenuTasks() { function offsetMenuOverlay () { let overlayOffset = document.querySelector(".ma__header__hamburger").getBoundingClientRect().top + menuBarHeight; if (width > 840) { - if (navigator.userAgent.indexOf("Firefox") !== -1) { - overlayOffset = overlayOffset - 14; - } else { - overlayOffset = overlayOffset -1; - } + overlayOffset = overlayOffset -1; } menuOverlay.style.top = overlayOffset + "px"; } From eaa3df4a5cdf2152a45c5984fcea665a97abc7c0 Mon Sep 17 00:00:00 2001 From: Tom Fleming Date: Fri, 25 Sep 2020 16:59:53 -0400 Subject: [PATCH 2/2] Added changelog - DP-20055 --- changelogs/DP-20055.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 changelogs/DP-20055.yml diff --git a/changelogs/DP-20055.yml b/changelogs/DP-20055.yml new file mode 100644 index 0000000000..5bbafae685 --- /dev/null +++ b/changelogs/DP-20055.yml @@ -0,0 +1,6 @@ +Removed: + - project: Patternlab + component: Header + description: Removed Firefox-specific code causing menu overlay issues in Firefox. (#1192) + issue: DP-20055 + impact: Patch